Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[unpleasant] Update editorial suggestions #447

Merged
merged 5 commits into from
Jul 1, 2024
Merged

[unpleasant] Update editorial suggestions #447

merged 5 commits into from
Jul 1, 2024

Conversation

SylviaZhaooo
Copy link
Collaborator

Resolve most comments in #445.

@netlify Netlify
Copy link

netlify bot commented May 22, 2024 •
edited
Loading

✅ Deploy Preview for taupe-gaufre-c4e660 ready!

Name Link
🔨 Latest commit 87b01e4
🔍 Latest deploy log https://app.netlify.com/sites/taupe-gaufre-c4e660/deploys/6681f5e3c28bdc0008db8e23
😎 Deploy Preview https://deploy-preview-447--taupe-gaufre-c4e660.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@SylviaZhaooo SylviaZhaooo requested a review from mmcky May 22, 2024 06:23
@github-actions GitHub Actions
Copy link

github-actions bot commented May 22, 2024 •
edited
Loading

🚀 Deployed on https://6681f8178770a6bc64ec81f4--taupe-gaufre-c4e660.netlify.app

@github-actions github-actions bot temporarily deployed to pull request May 22, 2024 06:25 Inactive
@github-actions github-actions bot temporarily deployed to pull request May 22, 2024 06:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 14:07 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 27, 2024 14:08 Inactive
mmcky
mmcky requested changes Jun 27, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@SylviaZhaooo Thanks for your work on this. Just included some suggestions for update.

lectures/unpleasant.md Outdated Show resolved Hide resolved
lectures/unpleasant.md Show resolved Hide resolved
lectures/unpleasant.md Outdated Show resolved Hide resolved
lectures/unpleasant.md Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pull request June 30, 2024 07:22 Inactive
@github-actions github-actions bot temporarily deployed to pull request June 30, 2024 07:22 Inactive
@mmcky
Copy link
Contributor

mmcky commented Jun 30, 2024

thanks @SylviaZhaooo if you have addressed the comments above. Would you mind clicking on the "Resolved comment". Thanks 👍

@SylviaZhaooo
Copy link
Collaborator Author

thanks @SylviaZhaooo if you have addressed the comments above. Would you mind clicking on the "Resolved comment". Thanks 👍
Thanks for reminding me. I have clicked on all "Resolved comments".

mmcky
mmcky approved these changes Jun 30, 2024
View reviewed changes
Copy link
Contributor

@mmcky mmcky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @SylviaZhaooo.

@jstac this is ready for final review.

@mmcky mmcky added the ready label Jun 30, 2024
jstac
jstac reviewed Jul 1, 2024
View reviewed changes
lectures/unpleasant.md Outdated Show resolved Hide resolved
jstac
jstac reviewed Jul 1, 2024
View reviewed changes
lectures/unpleasant.md Outdated Show resolved Hide resolved
jstac
jstac reviewed Jul 1, 2024
View reviewed changes
lectures/unpleasant.md Outdated Show resolved Hide resolved
@jstac
Copy link
Contributor

jstac commented Jul 1, 2024

Many thanks @SylviaZhaooo and @mmcky

Just some small changes requested.

@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:16 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:26 Inactive
@github-actions github-actions bot temporarily deployed to pull request July 1, 2024 00:28 Inactive
@SylviaZhaooo
Copy link
Collaborator Author

SylviaZhaooo commented Jul 1, 2024 •
edited
Loading

Many thanks @SylviaZhaooo and @mmcky

Just some small changes requested.

I made the changes as requested, and the conversations have been resolved.

@jstac
Copy link
Contributor

jstac commented Jul 1, 2024

Many thanks @SylviaZhaooo , much appreciated! merging.

@jstac jstac merged commit 04907d0 into main Jul 1, 2024
7 checks passed
@mmcky mmcky deleted the update_unpleasant branch July 1, 2024 00:45
@HumphreyYang HumphreyYang mentioned this pull request Jul 1, 2024
Closed
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mmcky mmcky mmcky approved these changes

@jstac jstac jstac left review comments

Assignees
No one assigned
Labels
ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@SylviaZhaooo @mmcky @jstac @HumphreyYang